Subprocess run with ignored non-zero exit PYL-W1510
Bug risk
Minor
3 years ago
—
3 years old
No results found
That’s all we can say right now.
Description
subprocess.run uses a default of check=False, which means that a nonzero exit code will be
ignored by default, instead of raising an exception.
You can ignore this issue if this behaviour is intended.
Bad practice
# Nonzero exit code will be ignored here
subprocess.run(['notify-send', '-u', 'critical', msg])
Recommended
# Exception will be raised for nonzero exit code
subprocess.run(['notify-send', '-u', 'critical', msg], check=True) # some comment