Function contains unused argument PYL-W0613
Anti-pattern
2 months ago
—
5 months old
Unused argument 'app'
28 await msg.edit("Reply to message")
29# get all id and send it to message
30@app.on_message(filters.command("allid", prefix) & filters.me)
31async def getAllId(app, msg):32 if msg.chat.type == "private":
33 await msg.edit("This is private chat")
34 returnUnused argument 'app'
39
40# get user info and send it to message
41@app.on_message(filters.command("info", prefix) & filters.me)
42async def getUserInfo(app, msg):43 if msg.reply_to_message:
44 await msg.edit(f"**User info**\n\n**First name:** `{msg.reply_to_message.from_user.first_name}`\n**Last name:** `{msg.reply_to_message.from_user.last_name}`\n**Username:** `{msg.reply_to_message.from_user.username}`\n**User id:** `{msg.reply_to_message.from_user.id}`")
45 else:Unused argument 'app'
21 await msg.edit(f"Chat id: `{msg.chat.id}`\nUser forward message id: `{msg.reply_to_message.forward_from_message_id}`")
22# get user id and send it to message
23@app.on_message(filters.command("uid", prefix) & filters.me)
24async def getUserId(app, msg):25 if msg.reply_to_message:
26 await msg.edit(f"User id: `{msg.reply_to_message.from_user.id}`")
27 else:Unused argument 'app'
4
5# get group id and send it to message
6@app.on_message(filters.command("id", prefix) & filters.me)
7async def getGroupId(app, msg): 8 if msg.chat.type == "private":
9 await msg.edit("This is private chat")
10 returnUnused argument 'app'
5
6# exec os command and send output to message
7@app.on_message(filters.command(["exec",">"], prefix) & filters.me)
8async def execCommand(app, msg): 9 if len(msg.command) < 2:
10 await msg.edit("Usage: `exec [command]`")
11 return
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42