A method that modifies its receiver value can have undesired behavior. The modification can also be the root of a bug because the actual value receiver could be a copy of that used at the calling site. This rule warns when a method modifies its receiver.

Bad practice

type data struct {
    num   int
    key   *string
    items map[string]bool
}

func (d data) vmethod() {
    d.num = 8
}

Recommended

type data struct {
    num   int
    key   *string
    items map[string]bool
}

func (d *data) vmethod() {
    d.num = 8
}

concourse / concourse

No ignore rules found