sort.Slice can only be used on slices GO-W5002
Bug risk
Major
7 days ago
—
a year old
sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1589 }
1590
1591 if vs, ok := interface{}(v).(Sortable); ok {
1592 sort.Slice(v, vs.Less)1593 }
1594
1595 return c.RenderJSON(v)sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1565 }
1566
1567 if vs, ok := interface{}(v).(Sortable); ok {
1568 sort.Slice(v, vs.Less)1569 }
1570
1571 return c.RenderJSON(v)sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1511 }
1512
1513 if vs, ok := interface{}(v).(Sortable); ok {
1514 sort.Slice(v, vs.Less)1515 }
1516
1517 return c.RenderJSON(v)sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1491 }
1492
1493 if vs, ok := interface{}(v).(Sortable); ok {
1494 sort.Slice(v, vs.Less)1495 }
1496
1497 return c.RenderJSON(v)sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1457 }
1458
1459 if vs, ok := interface{}(v).(Sortable); ok {
1460 sort.Slice(v, vs.Less)1461 }
1462
1463 return c.RenderJSON(v)
Description
sort.Slice can only be used only on slices and not arrays.
Bad practice
func foo() {
var arr [1]int
sort.Slice(arr, nil)
}
Recommended
func foo() {
slice := []int{3, 2, 1}
sort.Slice(slice, nil)
}