sort.Slice can only be used on slices GO-W5002
Bug risk
10 days ago
—
8 months old
sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Process
782 }
783
784 if vs, ok := interface{}(v).(Sortable); ok {
785 sort.Slice(v, vs.Less) 786 }
787
788 return c.RenderJSON(v)sort.Slice must only be called on slices, was called on int
762 }
763
764 if vs, ok := interface{}(v).(Sortable); ok {
765 sort.Slice(v, vs.Less) 766 }
767
768 return renderStatusCode(c, v)sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1497 }
1498
1499 if vs, ok := interface{}(v).(Sortable); ok {
1500 sort.Slice(v, vs.Less)1501 }
1502
1503 return c.RenderJSON(v)sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1473 }
1474
1475 if vs, ok := interface{}(v).(Sortable); ok {
1476 sort.Slice(v, vs.Less)1477 }
1478
1479 return c.RenderJSON(v)sort.Slice must only be called on slices, was called on *github.com/convox/convox/pkg/structs.Resource
1419 }
1420
1421 if vs, ok := interface{}(v).(Sortable); ok {
1422 sort.Slice(v, vs.Less)1423 }
1424
1425 return c.RenderJSON(v)
Description
sort.Slice can only be used only on slices and not arrays.
Bad practice
func foo() {
var arr [1]int
sort.Slice(arr, nil)
}
Recommended
func foo() {
slice := []int{3, 2, 1}
sort.Slice(slice, nil)
}