Unused method receiver RVV-B0013
Bug risk
Major
8 days ago
—
a year old
Method receiver 'p' is not referenced in method's body, consider removing it
4 return p.Domain
5}
6
7func (p *Provider) SystemStatus() (string, error) {8 return "running", nil
9}
Method receiver 'p' is not referenced in method's body, consider removing it
10 return fmt.Sprintf("%s/%s", p.Registry, app), true, nil
11}
12
13func (p *Provider) RepositoryPrefix() string {14 return ""
15}
Method receiver 'p' is not referenced in method's body, consider removing it
4 "github.com/convox/convox/pkg/manifest"
5)
6
7func (p *Provider) ManifestValidate(m *manifest.Manifest) error {8 return nil
9}
Method receiver 'p' is not referenced in method's body, consider removing it
16 return "nginx"
17}
18
19func (p *Provider) IngressInternalClass() string {20 return "nginx-internal"
21}
Method receiver 'p' is not referenced in method's body, consider removing it
12 return ans, nil
13}
14
15func (p *Provider) IngressClass() string {16 return "nginx"
17}
18
Description
Methods with unused receivers can be a symptom of unfinished refactoring or a bug. To keep the same method signature, omit the receiver name or '_' as it is unused.
Bad practice
func (f *Unix) Name() string {
return "unix"
}
func (_ *Unix) Name() string {
return "unix"
}
Recommended
func (*Unix) Name() string {
return "unix"
}