Unnecessary use of
json.loads() for file data PY-W0078
Anti-pattern
Major
a year ago
—
a year old
json.loads(northumbria2020Data) can be replaced with json.load(resp2)615 # Read and load data in panada dataframe
616 jsonFormatNorthumbria2021Data = json.loads(northumbria2021Data)
617 northumbria2021Dataset = pd.json_normalize(jsonFormatNorthumbria2021Data)
618 jsonFormatNorthumbria2020Data = json.loads(northumbria2020Data)619 northumbria2020Dataset = pd.json_normalize(jsonFormatNorthumbria2020Data)
620 # print(clevelandJuneDataset)
621json.loads(northumbria2020Data) can be replaced with json.load(resp2)560 # Read and load data in panada dataframe
561 jsonFormatNorthumbria2021Data = json.loads(northumbria2021Data)
562 northumbria2021Dataset = pd.json_normalize(jsonFormatNorthumbria2021Data)
563 jsonFormatNorthumbria2020Data = json.loads(northumbria2020Data)564 northumbria2020Dataset = pd.json_normalize(jsonFormatNorthumbria2020Data)
565 # print(clevelandJuneDataset)
566
Description
The json module provides two ways to read JSON data: a .loads() method that
accepts a JSON string, and a .load() method, that works on files directly.
So instead of reading a file manually and passing it to json.loads(), it is
recommended to use json.load() directly.
Bad practice
with open('data.json') as file:
data = json.loads(file.read()) # Reading file manually
class Socket:
def read_json(self, data):
json.loads(self.socket.read()) # Reading socket manually
self.socket.close()
Recommended
with open('data.json') as file:
data = json.load(file) # Directly passing the file object
class Socket:
def read_json(self, data):
json.load(self.socket) # Directly passing the socket object
self.socket.close()