Yoda conditions are named so because the literal value of the condition comes first while the variable comes second.

For instance,

if ("red" === color) {
    // ...
}

Yoda condition is fixed by switching the literal and variable.

This is called a Yoda condition because it reads as, "if red equals the color", similar to the way the Star Wars character Yoda speaks. Compare to the other way of arranging the operands:

if (color === "red") {
    // ...
}

This typically reads, "if the color equals red", which is arguably a more natural way to describe the comparison.

Bad Practice

if ("red" === color) {
    // ...
}

if (true == flag) {
    // ...
}

if (5 > count) {
    // ...
}

if (-1 < str.indexOf(substr)) {
    // ...
}

Recommended

if (color === "red") {
    // ...
}

if (flag === true) {
    // ...
}

if (count < 5) {
    // ...
}

if (str.indexOf(substr) > -1) {
    // ...
}

gururajbm / custom-select-tdd

No ignore rules found