When a loop specifies no break statement, the else clause will always execute when the loop sequence is empty, thus making it useless. It is recommended to have the statements under else in the same scope as the loop itself. If the else clause does not always execute at the end of a loop clause, then the code should add a break statement within the loop block.

Bad practice

while condition:
    # body doesn't have `break` anywhere
    ...
else:
    print("This is in the else block")

Recommended

while condition:
    if other_condition:
        break
    ...
else:
    print("This is in the else block")

Or, if there is no need for a break statement in the loop, refactor it like this:

while condition:
    # body doesn't have `break` anywhere
    ...

print("This is in the else block")

pnijhara / gitsome

No ignore rules found