Unused parameter in function RVV-B0012
Bug risk
Minor
7 days ago
—
3 years old
parameter 'root' seems to be unused, consider removing or renaming it as _
228 panic("implement me")
229}
230
231func (b *BeaconBlock) SetStateRoot(root []byte) {232 panic("implement me")
233}
234parameter 'ctx' seems to be unused, consider removing or renaming it as _
156}
157
158// Insert feature flags within the function to be enabled for Holesky testnet.
159func applyHoleskyFeatureFlags(ctx *cli.Context) {160}
161
162// ConfigureBeaconChain sets the global config basedparameter 'ctx' seems to be unused, consider removing or renaming it as _
152}
153
154// Insert feature flags within the function to be enabled for Sepolia testnet.
155func applySepoliaFeatureFlags(ctx *cli.Context) {156}
157
158// Insert feature flags within the function to be enabled for Holesky testnet.parameter 'ctx' seems to be unused, consider removing or renaming it as _
38// data=attestation.data,
39// signature=attestation.signature,
40// )
41func ConvertToIndexed(ctx context.Context, attestation interfaces.Attestation, committee []primitives.ValidatorIndex) (ethpb.IndexedAtt, error) { 42 attIndices, err := AttestingIndices(attestation.GetAggregationBits(), committee)
43 if err != nil {
44 return nil, errparameter 'epoch' seems to be unused, consider removing or renaming it as _
649// has_max_effective_balance = validator.effective_balance == MAX_EFFECTIVE_BALANCE
650// has_excess_balance = balance > MAX_EFFECTIVE_BALANCE
651// return has_eth1_withdrawal_credential(validator) and has_max_effective_balance and has_excess_balance
652func isPartiallyWithdrawableValidatorCapella(val *ethpb.Validator, balance uint64, epoch primitives.Epoch) bool {653 hasMaxBalance := val.EffectiveBalance == params.BeaconConfig().MaxEffectiveBalance
654 hasExcessBalance := balance > params.BeaconConfig().MaxEffectiveBalance
655 return HasETH1WithdrawalCredential(val) && hasExcessBalance && hasMaxBalance
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}