Missing return statement in method/function PHP-E1004
Bug risk
Critical
a year ago
—
2 years old
Method App\Http\Middleware\Authenticate::redirectTo() should return string|null but return statement is missing
14 */
15 protected function redirectTo($request)
16 {
17 if (! $request->expectsJson()) {18 return route('login');
19 }
20 }Method App\Http\Controllers\OccurrencesController::destroy() should return Illuminate\Http\Response but return statement is missing
89 */
90 public function destroy(Occurrences $occurrences)
91 {
92 //93 }
94}
Method App\Http\Controllers\OccurrencesController::update() should return Illuminate\Http\Response but return statement is missing
78 */
79 public function update(Request $request, Occurrences $occurrences)
80 {
81 //82 }
83
84 /**Method App\Http\Controllers\OccurrencesController::edit() should return Illuminate\Http\Response but return statement is missing
66 */
67 public function edit(Occurrences $occurrences)
68 {
69 //70 }
71
72 /**Method App\Http\Controllers\AddressController::store() should return Illuminate\Http\Response but return statement is missing
35 */
36 public function store(Request $request)
37 {
38 //39 }
40
41 /**
Description
This issue is raised if a method with a return type does not have a return statement of an appropriate type.
Bad practice
class User
{
public function greet(): string
{
$message = 'Hello, there!';
// missing return statement
}
}
class User
{
public function greet()
{
$message = function (): string {
$message = 'Hello, there!';
// missing return statement
};
return $message();
}
}
Recommended
class User
{
public function greet(): string
{
$message = 'Hello, there!';
return $message;
}
}
class User
{
public function greet()
{
$message = function (): string {
$message = 'Hello, there!';
return $message;
};
return $message();
}
}