Unused parameter in function RVV-B0012
Bug risk
Minor
11 days ago
—
3 years old
parameter 'forceYes' seems to be unused, consider removing or renaming it as _
249 return DeployWithConfig(ctx, appConfig, flag.GetYes(ctx))
250}
251
252func DeployWithConfig(ctx context.Context, appConfig *appconfig.Config, forceYes bool) (err error) {253 span := trace.SpanFromContext(ctx)
254
255 io := iostreams.FromContext(ctx)parameter 'ctx' seems to be unused, consider removing or renaming it as _
21 MachinesDeployStrategies = []string{"canary", "rolling", "immediate", "bluegreen"}
22)
23
24func (cfg *Config) Validate(ctx context.Context) (err error, extra_info string) { 25 if cfg == nil {
26 return errors.New("App config file not found"), ""
27 }parameter 'ctx' seems to be unused, consider removing or renaming it as _
933// This method aggregates images for machines in an app
934// If they are greater than 1, it suggest how to remove them and unblock the app
935// It also uses the bg_deployment_tag to suggest blue machines that can be safely deleted.
936func (bg *blueGreen) DetectMultipleImageVersions(ctx context.Context) error {937 imageToMachineIDs := map[string][]string{}
938 safeToDelete := map[string]int{}
939parameter 'org' seems to be unused, consider removing or renaming it as _
218 return &response.CreateAddOn.AddOn, nil
219}
220
221func DeterminePlan(ctx context.Context, org *fly.Organization) (*gql.ListAddOnPlansAddOnPlansAddOnPlanConnectionNodesAddOnPlan, error) {222
223 client := fly.ClientFromContext(ctx)
224parameter 'appName' seems to be unused, consider removing or renaming it as _
201 return s, nil
202}
203
204func RailsCallback(appName string, srcInfo *SourceInfo, plan *plan.LaunchPlan, flags []string) error {205 // Overall strategy: Install and use the dockerfile-rails gem to generate a Dockerfile.
206 //
207 // If a Dockerfile already exists, run the generator with the --skip flag to avoid overwriting it.
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}