Unused parameter in function RVV-B0012
Bug risk
Minor
5 hours ago
—
3 years old
parameter 'plan' seems to be unused, consider removing or renaming it as _
14 return nil
15}
16
17func DefaultObjectStorage(plan *LaunchPlan) ObjectStoragePlan {18 return ObjectStoragePlan{
19 TigrisObjectStorage: &TigrisObjectStoragePlan{},
20 }parameter 'app' seems to be unused, consider removing or renaming it as _
92 return matches, nil
93}
94
95func renderTable(ctx context.Context, volumes []fly.Volume, app *fly.AppBasic, out io.Writer, showHostStatus bool) error { 96 rows := make([][]string, 0, len(volumes))
97 unreachableVolumes := false
98 for _, volume := range volumes {parameter 'ctx' seems to be unused, consider removing or renaming it as _
92 return matches, nil
93}
94
95func renderTable(ctx context.Context, volumes []fly.Volume, app *fly.AppBasic, out io.Writer, showHostStatus bool) error { 96 rows := make([][]string, 0, len(volumes))
97 unreachableVolumes := false
98 for _, volume := range volumes {parameter 'flags' seems to be unused, consider removing or renaming it as _
126 return s, nil
127}
128
129func PhoenixCallback(appName string, _ *SourceInfo, plan *plan.LaunchPlan, flags []string) error {130 envEExPath := "rel/env.sh.eex"
131 envEExContents := `
132# configure node for distributed erlang with IPV6 supportparameter 'plan' seems to be unused, consider removing or renaming it as _
126 return s, nil
127}
128
129func PhoenixCallback(appName string, _ *SourceInfo, plan *plan.LaunchPlan, flags []string) error {130 envEExPath := "rel/env.sh.eex"
131 envEExContents := `
132# configure node for distributed erlang with IPV6 support
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}