Use of mark_safe() may expose cross-site scripting (XSS) vulnerabilities and should be reviewed. mark_safe explicitly marks a string as safe for (HTML) output purposes.

Django auto-escapes all output from template variable tags unless explicitly told not to. Use of mark_safe() function implies that the parameter is safe for client-side output without Django's automatic string escaping. It's a legitimate way of defining strings that are intended to be interpreted as HTML.

Using mark_safe() on an internally generated string is okay but becomes a security risk if used on unchecked user input.

Since this is an audit issue, some occurrences may be harmless here. The goal is to bring the issue to attention. Please make sure that the input string is trusted. If the occurrences don't seem to be valid, please feel free to ignore them.

When possible, use formathtml. It is safe as all arguments are passed through conditionalescape()

Bad practice

mark_safe("<b>%s</b> %s" % (user_input))

Recommended

format_html("<b>%s</b>, user_input)

References:

mark_safe
OWASP Top 10 2021 Category A03 - Injection
CWE 79 - Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')

uselotus / lotus

No ignore rules found